9bda5126a7
The available_storage_gib column in the VmHost comes from old times and have no use in the codebase. It causes confusion and this is cleaning up that column. Still for the sake of reaching the available storage size in the host, I added a new function which is a wrapper around storage_devices. The total_storage_gib is not used anywhere, so, we are dropping the column. For the sake of operator tooling, we add a wrapper function in the host model to find out the total_storage_gib from the storage devices.
136 lines
5.5 KiB
Ruby
136 lines
5.5 KiB
Ruby
# frozen_string_literal: true
|
|
|
|
require_relative "../model/spec_helper"
|
|
|
|
RSpec.describe Prog::LearnStorage do
|
|
describe "#start" do
|
|
it "exits, saving StorageDevice model instances" do
|
|
vmh = Prog::Vm::HostNexus.assemble("::1").subject
|
|
ls = described_class.new(Strand.new(stack: [{"subject_id" => vmh.id}]))
|
|
expect(ls.sshable).to receive(:cmd).with("df -B1 --output=target,size,avail ").and_return(<<EOS)
|
|
Mounted on 1B-blocks Avail
|
|
/ 205520896 99571712
|
|
/var/storage/devices/stor1 205520896 99571712
|
|
/var/storage/devices/stor2 3331416064 3331276800
|
|
EOS
|
|
expect(ls.sshable).to receive(:cmd).with("df -B1 --output=target,size,avail /var/storage").and_return(<<EOS)
|
|
Mounted on 1B-blocks Avail
|
|
/var/storage/devices/stor1 205520896 99571712
|
|
/var/storage/devices/stor2 3331416064 3331276800
|
|
EOS
|
|
|
|
expect { ls.start }.to exit({"msg" => "created StorageDevice records"}).and change {
|
|
StorageDevice.map(&:name).sort
|
|
}.from([]).to(%w[DEFAULT stor1 stor2])
|
|
end
|
|
|
|
it "exits, updating existing StorageDevice model instances" do
|
|
vmh = Prog::Vm::HostNexus.assemble("::1").subject
|
|
ls = described_class.new(Strand.new(stack: [{"subject_id" => vmh.id}]))
|
|
expect(ls.sshable).to receive(:cmd).with("df -B1 --output=target,size,avail ").and_return(<<EOS)
|
|
Mounted on 1B-blocks Avail
|
|
/ 6205520896 99571712
|
|
/var/storage/devices/stor1 6205520896 3099571712
|
|
/var/storage/devices/stor2 3331416064 1531276800
|
|
EOS
|
|
expect(ls.sshable).to receive(:cmd).with("df -B1 --output=target,size,avail /var/storage").and_return(<<EOS)
|
|
Mounted on 1B-blocks Avail
|
|
/var/storage/devices/stor1 6205520896 3099571712
|
|
/var/storage/devices/stor2 3331416064 1531276800
|
|
EOS
|
|
StorageDevice.create_with_id(vm_host_id: vmh.id, name: "stor1", available_storage_gib: 100, total_storage_gib: 100)
|
|
expect { ls.start }.to exit({"msg" => "created StorageDevice records"}).and change {
|
|
StorageDevice.map { |sd|
|
|
sd.values.slice(
|
|
:name, :available_storage_gib, :total_storage_gib
|
|
)
|
|
}.sort_by { _1[:name] }
|
|
}.from(
|
|
[{name: "stor1", total_storage_gib: 100, available_storage_gib: 100}]
|
|
).to(
|
|
[
|
|
{name: "DEFAULT", total_storage_gib: 5, available_storage_gib: 0},
|
|
{name: "stor1", total_storage_gib: 5, available_storage_gib: 2},
|
|
{name: "stor2", total_storage_gib: 3, available_storage_gib: 1}
|
|
]
|
|
)
|
|
|
|
expect(vmh.reload.available_storage_gib).to eq(3)
|
|
expect(vmh.reload.total_storage_gib).to eq(13)
|
|
end
|
|
end
|
|
|
|
describe Prog::LearnStorage, "#make_model_instances" do
|
|
subject(:ls) { described_class.new(Strand.new) }
|
|
|
|
let(:sshable) { instance_double(Sshable) }
|
|
let(:vmh) { instance_double(VmHost, id: "746976d6-315b-8f71-95e6-367c4ac068d7") }
|
|
|
|
before do
|
|
expect(ls).to receive(:sshable).and_return(sshable).at_least(:once)
|
|
expect(ls).to receive(:vm_host).and_return(vmh).at_least(:once)
|
|
end
|
|
|
|
it "can parse multiple file systems in /var/storage/NAME" do
|
|
expect(sshable).to receive(:cmd).with("df -B1 --output=target,size,avail ").and_return(<<EOS)
|
|
Mounted on 1B-blocks Avail
|
|
/run 3331420160 3328692224
|
|
/ 452564664320 381456842752
|
|
/dev/shm 16657084416 16605118464
|
|
/run/lock 5242880 5234688
|
|
/sys/firmware/efi/efivars 448412 74256
|
|
/boot 2024529920 1641877504
|
|
/var/storage/devices/stor1 205520896 99571712
|
|
/var/storage/devices/stor2 3331416064 3331276800
|
|
EOS
|
|
|
|
expect(sshable).to receive(:cmd).with("df -B1 --output=target,size,avail /var/storage").and_return(<<EOS)
|
|
Mounted on 1B-blocks Avail
|
|
/var/storage/devices/stor1 205520896 99571712
|
|
/var/storage/devices/stor2 3331416064 3331276800
|
|
EOS
|
|
|
|
expect(ls.make_model_instances.map(&:name)).to eq(%w[DEFAULT stor1 stor2])
|
|
end
|
|
|
|
it "can use any file system that is present at '/var/storage'" do
|
|
# First, the sshable is scanned for any file systems in
|
|
# /var/storage/devices. Iff there are none, a second command is
|
|
# sent to fill in the "DEFAULT" storage device.
|
|
expect(sshable).to receive(:cmd).with("df -B1 --output=target,size,avail ").and_return(<<EOS)
|
|
Mounted on 1B-blocks Avail
|
|
/run 3331420160 3328692224
|
|
/ 452564664320 381456842752
|
|
/dev/shm 16657084416 16605118464
|
|
/run/lock 5242880 5234688
|
|
/sys/firmware/efi/efivars 448412 74256
|
|
/boot 2024529920 1641877504
|
|
EOS
|
|
|
|
expect(sshable).to receive(:cmd).with("df -B1 --output=target,size,avail /var/storage").and_return(<<EOS)
|
|
Mounted on 1B-blocks Avail
|
|
/ 452564664320 381456842752
|
|
EOS
|
|
|
|
expect(ls.make_model_instances.map(&:name)).to eq(%w[DEFAULT])
|
|
end
|
|
end
|
|
|
|
describe Prog::LearnStorage::DfRecord do
|
|
it "can raise a header parse error" do
|
|
expect {
|
|
described_class.parse_all("")
|
|
}.to raise_error RuntimeError, "BUG: df header parse failed"
|
|
end
|
|
|
|
it "can raise a data parse error" do
|
|
expect {
|
|
described_class.parse_all(<<DF)
|
|
Mounted on 1B-blocks Avail
|
|
nope
|
|
DF
|
|
}.to raise_error RuntimeError, "BUG: df data parse failed"
|
|
end
|
|
end
|
|
end
|