0cbb51f433
We used to directly use request_body_params with double splat operator to pass parameters to Nexus::assemble. This is not a good practice because it opens the door to pass any parameter to Nexus::assemble. With this change we start to generate the parameters for Nexus::assemble from allowed_optional_parameters.
112 lines
4.7 KiB
Ruby
112 lines
4.7 KiB
Ruby
# frozen_string_literal: true
|
|
|
|
class Routes::Common::VmHelper < Routes::Common::Base
|
|
def list
|
|
if @mode == AppMode::API
|
|
dataset = project.vms_dataset
|
|
dataset = dataset.where(location: @location) if @location
|
|
result = dataset.authorized(@user.id, "Vm:view").paginated_result(
|
|
start_after: @request.params["start_after"],
|
|
page_size: @request.params["page_size"],
|
|
order_column: @request.params["order_column"]
|
|
)
|
|
|
|
{
|
|
items: Serializers::Vm.serialize(result[:records]),
|
|
count: result[:count]
|
|
}
|
|
else
|
|
vms = Serializers::Vm.serialize(project.vms_dataset.authorized(@user.id, "Vm:view").eager(:semaphores, :assigned_vm_address, :vm_storage_volumes).order(Sequel.desc(:created_at)).all, {include_path: true})
|
|
@app.instance_variable_set(:@vms, vms)
|
|
|
|
@app.view "vm/index"
|
|
end
|
|
end
|
|
|
|
def post(name)
|
|
Authorization.authorize(@user.id, "Vm:create", project.id)
|
|
fail Validation::ValidationFailed.new({billing_info: "Project doesn't have valid billing information"}) unless project.has_valid_payment_method?
|
|
|
|
required_parameters = ["public_key"]
|
|
required_parameters << "name" << "location" if @mode == AppMode::WEB
|
|
allowed_optional_parameters = ["size", "storage_size", "unix_user", "boot_image", "enable_ip4", "private_subnet_id"]
|
|
request_body_params = Validation.validate_request_body(params, required_parameters, allowed_optional_parameters)
|
|
assemble_params = request_body_params.slice(*allowed_optional_parameters).compact
|
|
|
|
# Generally parameter validation is handled in progs while creating resources.
|
|
# Since Vm::Nexus both handles VM creation requests from user and also Postgres
|
|
# service, moved the boot_image validation here to not allow users to pass
|
|
# postgres image as boot image while creating a VM.
|
|
if assemble_params["boot_image"]
|
|
Validation.validate_boot_image(assemble_params["boot_image"])
|
|
end
|
|
|
|
# Same as above, moved the size validation here to not allow users to
|
|
# pass gpu instance while creating a VM.
|
|
if assemble_params["size"]
|
|
parsed_size = Validation.validate_vm_size(assemble_params["size"], only_visible: true)
|
|
end
|
|
|
|
if assemble_params["storage_size"]
|
|
storage_size = Validation.validate_vm_storage_size(assemble_params["size"], assemble_params["storage_size"])
|
|
assemble_params["storage_volumes"] = [{size_gib: storage_size, encrypted: true}]
|
|
assemble_params.delete("storage_size")
|
|
end
|
|
|
|
if assemble_params["private_subnet_id"] && assemble_params["private_subnet_id"] != ""
|
|
ps = PrivateSubnet.from_ubid(assemble_params["private_subnet_id"])
|
|
if !ps || ps.location != @location
|
|
fail Validation::ValidationFailed.new({private_subnet_id: "Private subnet with the given id \"#{assemble_params["private_subnet_id"]}\" is not found in the location \"#{LocationNameConverter.to_display_name(@location)}\""})
|
|
end
|
|
Authorization.authorize(@user.id, "PrivateSubnet:view", ps.id)
|
|
end
|
|
assemble_params["private_subnet_id"] = ps&.id
|
|
|
|
requested_vm_core_count = parsed_size.nil? ? 1 : parsed_size.vcpu / 2
|
|
Validation.validate_core_quota(project, "VmCores", requested_vm_core_count)
|
|
|
|
st = Prog::Vm::Nexus.assemble(
|
|
request_body_params["public_key"],
|
|
project.id,
|
|
name: name,
|
|
location: @location,
|
|
**assemble_params.transform_keys(&:to_sym)
|
|
)
|
|
|
|
if @mode == AppMode::API
|
|
Serializers::Vm.serialize(st.subject, {detailed: true})
|
|
else
|
|
flash["notice"] = "'#{name}' will be ready in a few minutes"
|
|
@request.redirect "#{project.path}#{st.subject.path}"
|
|
end
|
|
end
|
|
|
|
def get
|
|
Authorization.authorize(@user.id, "Vm:view", @resource.id)
|
|
if @mode == AppMode::API
|
|
Serializers::Vm.serialize(@resource, {detailed: true})
|
|
else
|
|
@app.instance_variable_set(:@vm, Serializers::Vm.serialize(@resource, {detailed: true}))
|
|
@app.view "vm/show"
|
|
end
|
|
end
|
|
|
|
def delete
|
|
Authorization.authorize(@user.id, "Vm:delete", @resource.id)
|
|
@resource.incr_destroy
|
|
response.status = 204
|
|
@request.halt
|
|
end
|
|
|
|
def get_create
|
|
Authorization.authorize(@user.id, "Vm:create", project.id)
|
|
@app.instance_variable_set(:@subnets, Serializers::PrivateSubnet.serialize(project.private_subnets_dataset.authorized(@user.id, "PrivateSubnet:view").all))
|
|
@app.instance_variable_set(:@prices, @app.fetch_location_based_prices("VmCores", "VmStorage", "IPAddress"))
|
|
@app.instance_variable_set(:@has_valid_payment_method, project.has_valid_payment_method?)
|
|
@app.instance_variable_set(:@default_location, project.default_location)
|
|
@app.instance_variable_set(:@enabled_vm_sizes, Option::VmSizes.select { _1.visible && project.quota_available?("VmCores", _1.vcpu / 2) }.map(&:name))
|
|
|
|
@app.view "vm/create"
|
|
end
|
|
end
|