89213bc421
This allows you to modify an existing firewall rule. You can modify the cidr and/or description for the rule. While implementing this, I noticed the api endpoint always required a cidr parameter, which made it more difficult to only modify the description. Additionally, if you provided a cidr without a description parameter, it would erase the current description, which seems unlikely to be the desired behavior. This makes both the cidr and description parameters optional, and if the parameter is not given, treat it the same as providing the current parameter value.
24 lines
1.3 KiB
Ruby
24 lines
1.3 KiB
Ruby
# frozen_string_literal: true
|
|
|
|
require_relative "../spec_helper"
|
|
|
|
RSpec.describe Clover, "cli pg modify-firewall-rule" do
|
|
before do
|
|
expect(Config).to receive(:postgres_service_project_id).and_return(@project.id).at_least(:once)
|
|
end
|
|
|
|
it "modifies the cidr for the specified firewall rule for the database" do
|
|
cli(%w[pg eu-central-h1/test-pg create -s standard-2 -S 64])
|
|
pg = PostgresResource.first
|
|
fwr = pg.firewall_rules_dataset.first(cidr: "0.0.0.0/0")
|
|
expect(cli(%w[pg eu-central-h1/test-pg modify-firewall-rule -c 1.2.3.0/24 a/b], status: 400)).to start_with "! Invalid firewall rule id format\n"
|
|
expect(fwr.reload.cidr.to_s).to eq "0.0.0.0/0"
|
|
expect(cli(%W[pg eu-central-h1/test-pg modify-firewall-rule -c 1.2.3.0/24 #{fwr.ubid}])).to eq "PostgreSQL database firewall rule modified.\n rule id: #{fwr.ubid}\n cidr: 1.2.3.0/24\n description: \"\"\n"
|
|
expect(fwr.reload.cidr.to_s).to eq "1.2.3.0/24"
|
|
expect(fwr.description.to_s).to eq ""
|
|
expect(cli(%W[pg eu-central-h1/test-pg modify-firewall-rule -d] << "Example description" << fwr.ubid)).to eq "PostgreSQL database firewall rule modified.\n rule id: #{fwr.ubid}\n cidr: 1.2.3.0/24\n description: \"Example description\"\n"
|
|
expect(fwr.reload.cidr.to_s).to eq "1.2.3.0/24"
|
|
expect(fwr.description.to_s).to eq "Example description"
|
|
end
|
|
end
|