mirror of
https://github.com/TecharoHQ/anubis.git
synced 2025-11-28 08:30:23 +08:00
* fix(config): deprecate the report_as field for challenges This was a bad idea when it was added and it is irresponsible to continue to have it. It causes more UX problems than it fixes with slight of hand. Closes: #1310 Closes: #1307 Signed-off-by: Xe Iaso <me@xeiaso.net> * fix(policy): use the new logger for config validation messages Signed-off-by: Xe Iaso <me@xeiaso.net> * docs(admin/thresholds): remove this report_as setting Signed-off-by: Xe Iaso <me@xeiaso.net> --------- Signed-off-by: Xe Iaso <me@xeiaso.net>
79 lines
2 KiB
Go
79 lines
2 KiB
Go
package config
|
|
|
|
import (
|
|
"errors"
|
|
"fmt"
|
|
|
|
"github.com/TecharoHQ/anubis"
|
|
)
|
|
|
|
var (
|
|
ErrNoThresholdRulesDefined = errors.New("config: no thresholds defined")
|
|
ErrThresholdMustHaveName = errors.New("config.Threshold: must set name")
|
|
ErrThresholdMustHaveExpression = errors.New("config.Threshold: must set expression")
|
|
ErrThresholdChallengeMustHaveChallenge = errors.New("config.Threshold: a threshold with the CHALLENGE action must have challenge set")
|
|
ErrThresholdCannotHaveWeighAction = errors.New("config.Threshold: a threshold cannot have the WEIGH action")
|
|
|
|
DefaultThresholds = []Threshold{
|
|
{
|
|
Name: "legacy-anubis-behaviour",
|
|
Expression: &ExpressionOrList{
|
|
Expression: "weight > 0",
|
|
},
|
|
Action: RuleChallenge,
|
|
Challenge: &ChallengeRules{
|
|
Algorithm: "fast",
|
|
Difficulty: anubis.DefaultDifficulty,
|
|
},
|
|
},
|
|
}
|
|
)
|
|
|
|
type Threshold struct {
|
|
Expression *ExpressionOrList `json:"expression" yaml:"expression"`
|
|
Challenge *ChallengeRules `json:"challenge" yaml:"challenge"`
|
|
Name string `json:"name" yaml:"name"`
|
|
Action Rule `json:"action" yaml:"action"`
|
|
}
|
|
|
|
func (t Threshold) Valid() error {
|
|
var errs []error
|
|
|
|
if len(t.Name) == 0 {
|
|
errs = append(errs, ErrThresholdMustHaveName)
|
|
}
|
|
|
|
if t.Expression == nil {
|
|
errs = append(errs, ErrThresholdMustHaveExpression)
|
|
}
|
|
|
|
if t.Expression != nil {
|
|
if err := t.Expression.Valid(); err != nil {
|
|
errs = append(errs, err)
|
|
}
|
|
}
|
|
|
|
if err := t.Action.Valid(); err != nil {
|
|
errs = append(errs, err)
|
|
}
|
|
|
|
if t.Action == RuleWeigh {
|
|
errs = append(errs, ErrThresholdCannotHaveWeighAction)
|
|
}
|
|
|
|
if t.Action == RuleChallenge && t.Challenge == nil {
|
|
errs = append(errs, ErrThresholdChallengeMustHaveChallenge)
|
|
}
|
|
|
|
if t.Challenge != nil {
|
|
if err := t.Challenge.Valid(); err != nil {
|
|
errs = append(errs, err)
|
|
}
|
|
}
|
|
|
|
if len(errs) != 0 {
|
|
return fmt.Errorf("config: threshold entry for %q is not valid:\n%w", t.Name, errors.Join(errs...))
|
|
}
|
|
|
|
return nil
|
|
}
|